Control Structures

[ghenry]

Dear Master Monks,

In Permissions for a cgi script, I have a simple if/else structure. I have a line where I am burning a CD, and I use die to produce a error if something bad happens with that command.

I was wondering if I could jump to the else structure straight after die, as this is where all the error logs and e-mails are handled?

I thought of next and last, but they are for loops. Any ideas?

Thanks,

Gavin.

[gellyfish]

I would suggest changing the structure of the program slightly - factor out the code from the else condition and then rather than die you can use an additional if ... else in the first condition. If the condition is true continue to execute the existing code else go the error handling subroutine.

/J\

[ghenry]

I am testing if the iso exists and is small enough, I don't understand what the next condition to test against would be?

Maybe something like:

system (burning command);

if (my $cdburn = $?;) {
     carry on with code
}
else {
     errors
}

[zentara]

I like using a goto in those situations. :-) But others will surely beat me down for that. :-)

Or how about a DIE signal handler?

#!/usr/bin/perl

$SIG{__DIE__} = sub {
      open my $h, ">>", "fatal.log";
       print $h scalar localtime, ": @_";
       close $h;
  die @_;
};

die "ouch $!\n";

[tilly]

I've dealt with code that uses goto for error handling.

Suffice it to say that there is a reason that exception systems were invented...

[ghenry]

I think I'll take the simple approach and restructure my program like gellyfish recommends, but thanks though.

The above looks a little tricky, as I am struggling with a simple if/else ;-)

[tcf03]

I use something similar to the following in most of my cgi scripts when making system calls.

use CGI::Carp qw(fatalsToBrowser);

# rest of script

my $CMD="some command";

 system("$CMD");
 ( $? == 0 ) ? print "job success\n" : print "job failure\n";

[ghenry]

I love the look of this, because I really wanted to make the code look cleaner and I have been looking for a chance to use the Ternary Conditional Operator.

Could I swap out the print statements for subroutine calls and move the success and failure things to something like &failure and &success?

Something like:

my $CMD="some command";

 system("$CMD");
 ( $? == 0 ) ? &success($time, $hostname) : &failure($time, $hostname)
+;

and then shift these scalars inside the subroutines?

Thanks.

[ghenry]

I'll answer my own question ;-)

I tried it and it worked!

For your info:

Read more... (7 kB)