comment on

As previously noted your parsing is broken. If you really want to use REs something like this is *less broken*

use LWP::Simple;
use Data::Dumper;

my $content = get('http://www.perlmonks.com') or die $!;
$content =~ s/\s+/ /g;  # condense whitespace (optional)
my @meta = $content =~ m/<\s*meta([^>]+)>/gi;
for ( @meta ) {
    m/name\s*=\s*"([^"]+)/i     # double quotes
    || m/name\s*=\s*'([^']+)/i  # single quotes
    || m/name\s*=\s*(\S+)/i     # no quotes    
    || m/http-equiv\s*=\s*"([^"]+)/i 
    || m/http-equiv\s*=\s*'([^']+)/i 
    || m/http-equiv\s*=\s*(\S+)/i 
    || next;
    my $name = $1;

    m/content\s*=\s*"([^"]+)/i 
    || m/content\s*=\s*'([^']+)/i 
    || m/content\s*=\s*(\S+)/i 
    || next;

    $meta{$name} = $1;
}
print Dumper \%meta;
[download]

cheers

tachyon

In reply to Re: Critique/Test my first module MetaParser by tachyon
in thread Critique/Test my first module MetaParser by sulfericacid

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


We don't bite newbies here... much
	PerlMonks