what do you think about this alternative?
my @files = map { /^\s*(\S.*?)\s*$/ && $1 || "" } <$FILES>;
Quite bad actually. s/^\s+//; s/\s+$//; is common idiom enough that people instantly see what is being done (it is for instance mentioned in the perlfaq) - your solution requires more thinking to see what it does.
And then there's performance.
use Benchmark 'cmpthese';
our @data = ('foo', 'foo bar', ' foo', 'foo ', ' foo ', ' foo bar ');
+
cmpthese -1, {
faq => 'for my $x (@::data) {$_ = $x; s/^\s+//; s/\s+$//}',
Skeeve => 'for my $x (@::data) {$_ = $x; $_ = /^\s*(\S.*?)\s*$/ && $
+1 || ""}'
};
__END__
Rate Skeeve faq
Skeeve 19139/s -- -68%
faq 59077/s 209% --
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|