Re^2: How Much Is Too Much (on one line of code)? (rub)


Pathologically Eclectic Rubbish Lister
	PerlMonks

Re^2: How Much Is Too Much (on one line of code)? (rub)

by tye (Sage)

on Jun 18, 2007 at 22:52 UTC ( [id://621884]=note: print w/replies, xml )

Need Help??

in reply to Re: How Much Is Too Much (on one line of code)?
in thread How Much Is Too Much (on one line of code)?

That was closer to what I came up with but my primary reaction was that if one is spending more than a few seconds on such a very trivial matter (IMHO), then one must not have anything important to work on.

The apparent assumptions that $card->country() is always lower-case and never "0" were somewhat less trivial to me than the not-quite-perfect layout of the code, but I figured such aren't likely problems in the real environment. In any case, my code looked like:

my $displayCountry= do {
    my $c= uc $card->country();
    'GBR' eq $c  ||  '' eq $c  ?  ''  :  "[$c]";
};
[download]

which I still consider only trivially different from most of the other gyrations offered. This of course brings to mind the rude term "turd polishing" but this seem more like "rice polishing", making sure each individual grain is shiny before boiling them all. (:

- tye