I think what you meant to ask is if there is too much going on in that statement. I will give a weighted answer of 70% for "just too much" and 30% for "poorly worded". With that said I didn't really like any of the alternatives that much though shmen's ( Re: How Much Is Too Much (on one line of code)?
) came close (I consider &&= a bit too obscure so I tend to avoid it).
Here's some untested code that I mostly like:
sub get_country {
my( $card ) = @_;
my $tmp= $card->country;
return "" if ! defined $tmp || $tmp eq "" || $tmp eq 'gbr';
return uc "[$tmp]"
}
my $country = get_country( $card );
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|