I know Damian Conway gives this advice on PBP page 31, but he still can't make me like nested ternaries. If you're going to use his style, I suggest lining up the croak with the (undef, @_) and @_. Your code is readable, in any case.
It is considered bad form to use a ternary structure to do things other than return a single value, in general, but I don't mind your use of croak as the "if all else fails" condition. (Update: I later saw this in PBP as well, on page 258 to be exact.)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|