comment on

After applying PerlTidy the following looks interesting:

            open THEFILE, "$config{'basepath'}$key/$file";
            my (
                $title,     $reserve, $inc,     $desc,     $image1,
                $image2,    $image3,  $image4,  $thumb1,   $thumb2,
                $thumb3,    $thumb4,  $dutch,   $qty,      $bold,
                $highlight, $feat,    $catfeat, $grabber,  $relist,
                $buyit,     $gallery, $counter, $ship1,    $ship2,
                $ship3,     $ship4,   $ship5,   $shipcost, $location,
                $pay1,      $pay2,    $pay3,    $pay4,     $pay5,
                $pay6,      $pay7,    $pay8,    $pay9,     $paypal,
                $idata1,    $idata2,  $idata3,  $idata4,   $idata5,
                $idata6,    $idata7,  $idata8,  $idata9,   @bids
                ) = <THEFILE>;
            my (
                $alias, $email, $bid,  $time, $add1,
                $add2,  $add3,  $oqty, $qtysold
                ) = &read_bid ($bids[$#bids]);
[download]

Notice that @bids is set by reading a file (my (..., @bids) = <THEFILE>) and that then, without any checking at all, the presumed to exist last element is accessed. If there are too few lines in the input file then the 'last element access' will fail.

Looks to me like there is far too much string and bubble gum involved in holding this system together!

Perl is environmentally friendly - it saves trees

In reply to Re^3: Ignorance Isnt Always Bliss by GrandFather
in thread Ignorance Isnt Always Bliss by Baffled

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


P is for Practical
	PerlMonks